Fixed minor typography stuff. #6

Merged
miraty merged 3 commits from Cpm/libreqr:cpm-typo1 into master 11 months ago
Cpm commented 11 months ago

Some minor typography fixes. Hoping to help.

Some minor typography fixes. Hoping to help.
miraty reviewed 11 months ago
locales/en.php Outdated
<a href='https://en.wikipedia.org/wiki/QR_code'>QR code on Wikipedia</a>.
",
'metaText_legal' => "LibreQR " . $libreqrVersion . " is a free software whose <a href='https://code.antopie.org/miraty/libreqr/'>source code</a> is available under the terms of the <abbr title='GNU Affero General Public License version 3 or any later version'><a href='LICENSE.html'>AGPLv3</a>+</abbr>.",
'metaText_legal' => "LibreQR " . $libreqrVersion . " is a free software whose <a href='https://code.antopie.org/miraty/libreqr/'>source code</a> is available under the terms of the <abbr title='GNU Affero General Public License version 3 or any later version'><a href='LICENSE.html'>AGPLv3+</a></abbr>.",
Poster
Owner

The LICENSE.html file is only the "GNU Affero General Public License version 3". The "+" symbol means "or any later version", so the <a> element should not contain it.

The LICENSE.html file is only the "GNU Affero General Public License version 3". The "+" symbol means "or any later version", so the `<a>` element should not contain it.
Cpm commented 11 months ago
Poster

The LICENSE.html file contains many explainations about the "later". So it can be considered as good.
But you are the main project maintener, so I do as you want. I reverted the modification in my branch :-)

The LICENSE.html file contains many explainations about the "later". So it can be considered as good. But you are the main project maintener, so I do as you want. I reverted the modification in my branch :-)
miraty reviewed 11 months ago
$loc = array(
'subtitle' => "Générateur de codes QR",
'description' => "Générez des codes QR librement. Choisissez le contenu, la taille, les couleurs...",
'description' => "Générez des codes QR librement. Choisissez le contenu, la taille, les couleurs",
Poster
Owner

It should also be applied to the english version.

It should also be applied to the english version.
Cpm commented 11 months ago
Poster

I am not an expert in english typography :D
But it seems to be the same in English:
https://en.wikipedia.org/wiki/Ellipsis#In_American_English

Ok so I applied the modification in the branch and now it is part of this current merge request \o/

I am not an expert in english typography :D But it seems to be the same in English: https://en.wikipedia.org/wiki/Ellipsis#In_American_English Ok so I applied the modification in the branch and now it is part of this current merge request \o/
miraty marked this conversation as resolved
miraty reviewed 11 months ago
<h3>What's a QR code?</h3>
A QR code is a 2 dimensions barcode in which a text is written in binary. It can be decoded with a device equipped with a photo sensor and an adequate software.
<a href='https://en.wikipedia.org/wiki/QR_code'>QR code on Wikipedia</a>
<a href='https://en.wikipedia.org/wiki/QR_code'>QR code on Wikipedia</a>.
Poster
Owner

I'm divided on this point.

"QR code on Wikipedia" is not a sentence, so there is no rule that requires to use a dot here. This is just a question of aesthetics, and I personaly prefer the version without the dot.

But if you really prefer the dotted version, I can accept it.

I'm divided on this point. "QR code on Wikipedia" is not a sentence, so there is no rule that requires to use a dot here. This is just a question of aesthetics, and I personaly prefer the version without the dot. But if you really prefer the dotted version, I can accept it.
Cpm commented 11 months ago
Poster

A sentence does not need a verb to be a sentence. Almost any group of words is a sentence, except titles or other fantasies. There, it is just after a sentence so… :-)

A sentence does not need a verb to be a sentence. Almost any group of words is a sentence, except titles or other fantasies. There, it is just after a sentence so… :-)
Poster
Owner

As you want.

As you want.
miraty marked this conversation as resolved
miraty closed this pull request 11 months ago
miraty reopened this pull request 11 months ago
miraty merged commit eaee58c93d into master 11 months ago
Owner

Thank you for your involvement :)

Thank you for your involvement :)
The pull request has been merged as eaee58c93d.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.