Fixed minor typography stuff. #6
No reviewers
Labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: miraty/libreqr#6
Loading…
Reference in a new issue
No description provided.
Delete branch "Cpm/libreqr:cpm-typo1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Some minor typography fixes. Hoping to help.
@ -46,2 +45,3 @@<a href='https://en.wikipedia.org/wiki/QR_code'>QR code on Wikipedia</a>.",'metaText_legal' => "LibreQR " . $libreqrVersion . " is a free software whose <a href='https://code.antopie.org/miraty/libreqr/'>source code</a> is available under the terms of the <abbr title='GNU Affero General Public License version 3 or any later version'><a href='LICENSE.html'>AGPLv3</a>+</abbr>.",'metaText_legal' => "LibreQR " . $libreqrVersion . " is a free software whose <a href='https://code.antopie.org/miraty/libreqr/'>source code</a> is available under the terms of the <abbr title='GNU Affero General Public License version 3 or any later version'><a href='LICENSE.html'>AGPLv3+</a></abbr>.",The LICENSE.html file is only the "GNU Affero General Public License version 3". The "+" symbol means "or any later version", so the
<a>element should not contain it.The LICENSE.html file contains many explainations about the "later". So it can be considered as good.
But you are the main project maintener, so I do as you want. I reverted the modification in my branch :-)
@ -2,3 +2,3 @@$loc = array('subtitle' => "Générateur de codes QR",'description' => "Générez des codes QR librement. Choisissez le contenu, la taille, les couleurs...",'description' => "Générez des codes QR librement. Choisissez le contenu, la taille, les couleurs…",It should also be applied to the english version.
I am not an expert in english typography :D
But it seems to be the same in English:
https://en.wikipedia.org/wiki/Ellipsis#In_American_English
Ok so I applied the modification in the branch and now it is part of this current merge request \o/
@ -43,3 +43,3 @@<h3>What's a QR code?</h3>A QR code is a 2 dimensions barcode in which a text is written in binary. It can be decoded with a device equipped with a photo sensor and an adequate software.<a href='https://en.wikipedia.org/wiki/QR_code'>QR code on Wikipedia</a><a href='https://en.wikipedia.org/wiki/QR_code'>QR code on Wikipedia</a>.I'm divided on this point.
"QR code on Wikipedia" is not a sentence, so there is no rule that requires to use a dot here. This is just a question of aesthetics, and I personaly prefer the version without the dot.
But if you really prefer the dotted version, I can accept it.
A sentence does not need a verb to be a sentence. Almost any group of words is a sentence, except titles or other fantasies. There, it is just after a sentence so… :-)
As you want.
Thank you for your involvement :)