Fixed minor typography stuff. #6

Merged
miraty merged 3 commits from Cpm/libreqr:cpm-typo1 into master 1 year ago
  1. 4
      locales/en.php
  2. 4
      locales/fr.php

4
locales/en.php

@ -1,7 +1,7 @@
<?php
$loc = array(
'subtitle' => "QR codes generator",
'description' => "Generate QR codes freely. Choose content, size, colors...",
'description' => "Generate QR codes freely. Choose content, size, colors",
'label_content' => "Text to encode",
'label_redondancy' => "Redondancy rate",
@ -42,7 +42,7 @@ $loc = array(
'metaText_qr' => "
<h3>What's a QR code?</h3>
A QR code is a 2 dimensions barcode in which a text is written in binary. It can be decoded with a device equipped with a photo sensor and an adequate software.
<a href='https://en.wikipedia.org/wiki/QR_code'>QR code on Wikipedia</a>
<a href='https://en.wikipedia.org/wiki/QR_code'>QR code on Wikipedia</a>.
miraty marked this conversation as resolved
Review

I'm divided on this point.

"QR code on Wikipedia" is not a sentence, so there is no rule that requires to use a dot here. This is just a question of aesthetics, and I personaly prefer the version without the dot.

But if you really prefer the dotted version, I can accept it.

I'm divided on this point. "QR code on Wikipedia" is not a sentence, so there is no rule that requires to use a dot here. This is just a question of aesthetics, and I personaly prefer the version without the dot. But if you really prefer the dotted version, I can accept it.
Cpm commented 1 year ago
Review

A sentence does not need a verb to be a sentence. Almost any group of words is a sentence, except titles or other fantasies. There, it is just after a sentence so… :-)

A sentence does not need a verb to be a sentence. Almost any group of words is a sentence, except titles or other fantasies. There, it is just after a sentence so… :-)
Review

As you want.

As you want.
",
'metaText_legal' => "LibreQR " . $libreqrVersion . " is a free software whose <a href='https://code.antopie.org/miraty/libreqr/'>source code</a> is available under the terms of the <abbr title='GNU Affero General Public License version 3 or any later version'><a href='LICENSE.html'>AGPLv3</a>+</abbr>.",
miraty marked this conversation as resolved
Cpm commented 1 year ago
Review

The LICENSE.html file contains many explainations about the "later". So it can be considered as good.
But you are the main project maintener, so I do as you want. I reverted the modification in my branch :-)

The LICENSE.html file contains many explainations about the "later". So it can be considered as good. But you are the main project maintener, so I do as you want. I reverted the modification in my branch :-)

4
locales/fr.php

@ -1,7 +1,7 @@
<?php
$loc = array(
'subtitle' => "Générateur de codes QR",
'description' => "Générez des codes QR librement. Choisissez le contenu, la taille, les couleurs...",
'description' => "Générez des codes QR librement. Choisissez le contenu, la taille, les couleurs",
miraty marked this conversation as resolved
Review

It should also be applied to the english version.

It should also be applied to the english version.
Cpm commented 1 year ago
Review

I am not an expert in english typography :D
But it seems to be the same in English:
https://en.wikipedia.org/wiki/Ellipsis#In_American_English

Ok so I applied the modification in the branch and now it is part of this current merge request \o/

I am not an expert in english typography :D But it seems to be the same in English: https://en.wikipedia.org/wiki/Ellipsis#In_American_English Ok so I applied the modification in the branch and now it is part of this current merge request \o/
'label_content' => "Texte à encoder",
'label_redondancy' => "Taux de redondance",
@ -42,7 +42,7 @@ $loc = array(
'metaText_qr' => "
<h3>Qu'est-ce qu'un code QR ?</h3>
Un code QR est un code-barres en 2 dimensions dans lequel du texte est inscrit en binaire. Il peut être décodé avec un appareil muni d'un capteur photo et d'un logiciel adéquat.
<a href='https://fr.wikipedia.org/wiki/Code_QR'>Code QR sur Wikipédia</a>
<a href='https://fr.wikipedia.org/wiki/Code_QR'>Code QR sur Wikipédia</a>.
",
'metaText_legal' => "LibreQR " . $libreqrVersion . " est un logiciel libre dont le <a href='https://code.antopie.org/miraty/libreqr/'>code source</a> est disponible selon les termes de l'<abbr title='GNU Affero General Public License version 3 ou toute version ultérieure'><a href='LICENSE.html'>AGPLv3</a>+</abbr>.",

Loading…
Cancel
Save