miraty/libreqr
miraty
/
libreqr
1
1
Fork 4
Code Issues Pull Requests Releases 8 Activity

Fixed minor typography stuff. #6

Merged
miraty merged 3 commits from Cpm/libreqr:cpm-typo1 into master 2020-12-29 15:29:09 +01:00
Conversation 1 Commits 3 Files Changed 2 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e49691a752 - Show all commits

2
locales/en.php
View File

@ -44,7 +44,7 @@ $loc = array(
A QR code is a 2 dimensions barcode in which a text is written in binary. It can be decoded with a device equipped with a photo sensor and an adequate software.
<a href='https://en.wikipedia.org/wiki/QR_code'>QR code on Wikipedia</a>.
miraty marked this conversation as resolved
miraty commented 2020-12-29 14:55:58 +01:00
Review
Copy Link

I'm divided on this point.

"QR code on Wikipedia" is not a sentence, so there is no rule that requires to use a dot here. This is just a question of aesthetics, and I personaly prefer the version without the dot.

But if you really prefer the dotted version, I can accept it.

I'm divided on this point. "QR code on Wikipedia" is not a sentence, so there is no rule that requires to use a dot here. This is just a question of aesthetics, and I personaly prefer the version without the dot. But if you really prefer the dotted version, I can accept it.
Cpm commented 2020-12-29 15:06:07 +01:00
Review
Copy Link

A sentence does not need a verb to be a sentence. Almost any group of words is a sentence, except titles or other fantasies. There, it is just after a sentence so… :-)

A sentence does not need a verb to be a sentence. Almost any group of words is a sentence, except titles or other fantasies. There, it is just after a sentence so… :-)
miraty commented 2020-12-29 15:26:08 +01:00
Review
Copy Link

As you want.

As you want.
",
'metaText_legal' => "LibreQR " . $libreqrVersion . " is a free software whose <a href='https://code.antopie.org/miraty/libreqr/'>source code</a> is available under the terms of the <abbr title='GNU Affero General Public License version 3 or any later version'><a href='LICENSE.html'>AGPLv3+</a></abbr>.",
'metaText_legal' => "LibreQR " . $libreqrVersion . " is a free software whose <a href='https://code.antopie.org/miraty/libreqr/'>source code</a> is available under the terms of the <abbr title='GNU Affero General Public License version 3 or any later version'><a href='LICENSE.html'>AGPLv3</a>+</abbr>.",
miraty commented 2020-12-29 14:28:32 +01:00
Outdated
Review
Copy Link

The LICENSE.html file is only the "GNU Affero General Public License version 3". The "+" symbol means "or any later version", so the <a> element should not contain it.

The LICENSE.html file is only the "GNU Affero General Public License version 3". The "+" symbol means "or any later version", so the `<a>` element should not contain it.
Cpm commented 2020-12-29 14:58:49 +01:00
Review
Copy Link

The LICENSE.html file contains many explainations about the "later". So it can be considered as good.
But you are the main project maintener, so I do as you want. I reverted the modification in my branch :-)

The LICENSE.html file contains many explainations about the "later". So it can be considered as good. But you are the main project maintener, so I do as you want. I reverted the modification in my branch :-)
'opensearch_description' => "Generate QR codes from your search or address bar",
'opensearch_actionName' => "Generate QR codes from your search or address bar",

2
locales/fr.php
View File

@ -44,7 +44,7 @@ $loc = array(
Un code QR est un code-barres en 2 dimensions dans lequel du texte est inscrit en binaire. Il peut être décodé avec un appareil muni d'un capteur photo et d'un logiciel adéquat.
<a href='https://fr.wikipedia.org/wiki/Code_QR'>Code QR sur Wikipédia</a>.
",
'metaText_legal' => "LibreQR " . $libreqrVersion . " est un logiciel libre dont le <a href='https://code.antopie.org/miraty/libreqr/'>code source</a> est disponible selon les termes de l'<abbr title='GNU Affero General Public License version 3 ou toute version ultérieure'><a href='LICENSE.html'>AGPLv3+</a></abbr>.",
'metaText_legal' => "LibreQR " . $libreqrVersion . " est un logiciel libre dont le <a href='https://code.antopie.org/miraty/libreqr/'>code source</a> est disponible selon les termes de l'<abbr title='GNU Affero General Public License version 3 ou toute version ultérieure'><a href='LICENSE.html'>AGPLv3</a>+</abbr>.",
'opensearch_description' => "Générez des codes QR depuis votre barre de recherche ou d'adresse",
'opensearch_actionName' => "Générez des codes QR depuis votre barre de recherche ou d'adresse",